Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4153: slog Migration #1068

Merged
merged 22 commits into from
Jan 10, 2025
Merged

BED-4153: slog Migration #1068

merged 22 commits into from
Jan 10, 2025

Conversation

wes-mil
Copy link
Contributor

@wes-mil wes-mil commented Jan 10, 2025

Description

Migration to slog

Motivation and Context

This PR addresses:
BED-4153
BED-5056

Why is this change required? What problem does it solve?

slog is much more powerful than the previous logging solution and allows for contextual logging throughout the app.

How Has This Been Tested?

App build and runs locally. All tests passing.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Copy link
Contributor

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing significant stands out. Large changeset but lots of find and replace refactor so my concern here is low.

Please acquire one more review sign-off before merging.

@wes-mil wes-mil merged commit b90fd6c into main Jan 10, 2025
5 checks passed
@wes-mil wes-mil deleted the BED-4153 branch January 10, 2025 19:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants